Minor: Output elapsed time for sql logic test #13718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm.... the record high for windows platform is which takes 100x less for other platforms |
|
Folks appreciate if I can have a quick review on it so it can unblock me to investigate Windows slowness further |
alamb
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Looks good to me -- thank you @comphead
I ran this locally and it produced this output:
Running bin/sqllogictests.rs (target/debug/deps/sqllogictests-52523e4652075e1b)
Executed "same_column_name_cross_join.slt". Took 49.828334ms
Executed "strings.slt". Took 53.409791ms
Executed "options.slt". Took 58.914208ms
Executed "wildcard.slt". Took 59.238708ms
Executed "agg_func_substitute.slt". Took 60.206666ms
Executed "references.slt". Took 79.878958ms
Executed "binary.slt". Took 80.564833ms
Executed "push_down_filter.slt". Took 32.206125ms
Executed "arrow_files.slt". Took 97.147667ms
Executed "binary_view.slt". Took 40.529792ms
Executed "projection.slt". Took 56.37425ms
Executed "misc.slt". Took 3.956583ms
Executed "csv_files.slt". Took 129.71475ms
Executed "create_external_table.slt". Took 103.675708ms
Executed "identifiers.slt". Took 46.293125ms
Executed "aggregates_topk.slt". Took 70.157875ms
Executed "math.slt". Took 191.994167ms
Executed "ddl.slt". Took 210.443791ms
Executed "coalesce.slt". Took 91.933458ms
Executed "repartition.slt". Took 44.428709ms
Executed "cse.slt". Took 92.402459ms
...
👍
|
Thanks @alamb |
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 11, 2024
* Minor: Output elapsed time for sql logic test
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 15, 2024
* Minor: Output elapsed time for sql logic test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Found when was working on #13710
Rationale for this change
The test running time is different depending on OS so it would be useful to know the exact SLT execution time.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?